Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Markdown comments to MDX comments #545

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

chvmvd
Copy link
Contributor

@chvmvd chvmvd commented Nov 4, 2023

Docusaurusは現在もMarkdown形式でのコメントをサポートしているが、近いうちにサポートされなくなるので、移行した。#531

しかし、#544 が発生し、とりあえず prettier-ignoreなどを使い一旦逃げた。

Copy link

cloudflare-workers-and-pages bot commented Nov 4, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: b02f227
Status: ✅  Deploy successful!
Preview URL: https://6867f1a8.utcode-learn.pages.dev
Branch Preview URL: https://migrate-markdown-comments-to.utcode-learn.pages.dev

View logs

@chvmvd chvmvd requested review from aster-void and chelproc November 4, 2023 16:05
@chvmvd chvmvd force-pushed the migrate-markdown-comments-to-mdx-comments branch from a3c8479 to b02f227 Compare November 4, 2023 16:08
@chvmvd chvmvd mentioned this pull request Nov 4, 2023
@@ -229,7 +229,9 @@ document.write(`<p>空の配列の最大値は ${findMaxNumber([])} です。</p

</Answer>

<!-- オブジェクトはまだ扱っていないためコメントアウト
{/* prettier-ignore */}
{/* オブジェクトはまだ扱っていないためコメントアウト
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これオブジェクトに移動して消した記憶があります...
今度消し直しておきます

Copy link
Contributor

@aster-void aster-void left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いいと思います!

Base automatically changed from migrate-to-docusaurus-3 to master November 5, 2023 05:35
@chvmvd chvmvd merged commit 6cb84a4 into master Nov 5, 2023
3 checks passed
@chvmvd chvmvd deleted the migrate-markdown-comments-to-mdx-comments branch November 5, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants