Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expressの章の改定 #410

Merged
merged 7 commits into from
Oct 5, 2023
Merged

Expressの章の改定 #410

merged 7 commits into from
Oct 5, 2023

Conversation

kazukinumazato
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 1, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f473ea5
Status: ✅  Deploy successful!
Preview URL: https://595e86ec.utcode-learn.pages.dev
Branch Preview URL: https://combine-http-and-express.utcode-learn.pages.dev

View logs

@kazukinumazato kazukinumazato changed the title レビューの反映 Expressの章の改定 Oct 1, 2023
docs/3-web-servers/04-server/index.md Outdated Show resolved Hide resolved
@@ -223,7 +221,7 @@ app.listen(3000);
```

```html title=template.ejs
<!doctype html>
<!DOCTYPE html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettierのバージョンが古いので、手元でnpm ciしてください。

@chvmvd
Copy link
Contributor

chvmvd commented Oct 1, 2023

追加でリンクが大量に切れてるので、修正お願いします!

Copy link
Contributor

@chvmvd chvmvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazukinumazato kazukinumazato merged commit 606ec48 into master Oct 5, 2023
2 checks passed
@kazukinumazato kazukinumazato deleted the combine-http-and-express branch October 5, 2023 04:19
@chvmvd chvmvd mentioned this pull request Oct 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants