Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USWDS-Sandbox - POAM: November ‘24 #167

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

USWDS-Sandbox - POAM: November ‘24 #167

wants to merge 5 commits into from

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Nov 18, 2024 •
edited
Loading

Summary

Dependency updates for November 2024

Breaking change

This is not a breaking change.

Related issue

USWDS-Team - POAM: November '24

Preview link

Preview link →

Major changes

  • Removed npm-run-all dependency because it was causing 2 high vulnerabilities
  • Updated script to natively run multiple scripts.

Dependency updates

Before

2 high severity vulnerabilities

After

found 0 vulnerabilities
Depenency Name Old Version New version
@uswds/uswds 3.9.0 3.10.0
npm-run-all 4.1.5 -
snyk ^1.1293.1 ^1.1294.0

Testing and review

  1. Confirm there are no installation errors
  2. Confirm there are no build errors
  3. Confirm there are no test errors
  4. Confirm federalist, init, and start scripts work as intended

@mahoneycm mahoneycm requested a review from a team as a code owner November 18, 2024 22:36
@mahoneycm mahoneycm mentioned this pull request Nov 18, 2024
Open
7 tasks
cathybaptista
cathybaptista approved these changes Nov 25, 2024
View reviewed changes
Copy link

@cathybaptista cathybaptista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm , LGTM, everything ran as expected. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathybaptista cathybaptista cathybaptista approved these changes

@mejiaj mejiaj Awaiting requested review from mejiaj

@amyleadem amyleadem Awaiting requested review from amyleadem

@mlloydbixal mlloydbixal Awaiting requested review from mlloydbixal

@RachelCorsino RachelCorsino Awaiting requested review from RachelCorsino

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahoneycm @cathybaptista