Adds OptionalValidator
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #62 `Optional validator`
ghost
merged commit 
madhikarma
reviewed
May 16, 2018
| conditions = [PresentCondition()] | ||
| } | ||
|
|
||
| public init(conditions: [Condition], primaryCondition: Condition = PresentCondition()) { |
There was a problem hiding this comment.
Is there a use case for this one? i.e. a PresentCondition being primary followed by a single PrimaryCondition in the conditions array
|
|
||
| public func checkConditions(_ text: String?) -> [Condition]? { | ||
| if primaryCondition.check(text) { | ||
| let violations = conditions.filter { !($0.check(text)) } |
There was a problem hiding this comment.
This is fine, I'm thinking if there are other ways to do this e.g. using compactMap but don't want it to become too terse or hard to reason with / understand either.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #62
Optional validatorby addingOptionalValidator.Details
The
OptionalValidatorhas two stages of conditions. First theprimaryConditionis checked. If it is met, then the subsequentconditionare checked for violations. If theprimaryConditionis not met, then no violation is returned.As an example, say you only want violations to show if there is text in the field, but otherwise ignore it as it is an optional field in a form. In this case you would use a
PresentConditionas theprimaryConditionand your subsequent validation requirements as theconditions.