-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RGI #786
Conversation
@@ -5211,6 +5211,9 @@ tools: | |||
owner: iuc | |||
tool_panel_section_label: Virology | |||
|
|||
- name: rgi # Includes a DM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Helena. This is not an IUC tool and should go into some other file I guess. We might also need to check every version - so not auto-update this one?
This also looks a bit non-standard and I'm wondering if there is more to setup up.
#if $db_opts.db_opts_selector == "default":
export DB_PATH='${__tool_data_path__}/rgi_databases/_default' &&
export DATA_PATH="\$_GALAXY_JOB_TMP_DIR" &&
mkdir -p "\$DB_PATH" &&
#end if
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you're right @ non-iuc, and agreed at not auto-updating. Do you have a preference for which file?
I'm wondering if there is more to setup up.
I've run this in my internal galaxy, and seems to run fine once the included DM's been run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the DM (which also should be in a separate repo) is working but there is a 3rd option which is "default" and I'm not sure how this should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I guess the default option would not work. I have not been using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the DM (which also should be in a separate repo) is working but there is a 3rd option which is "default" and I'm not sure how this should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Did you intend to paste the same comment again?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, just bad internet at the conference ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should we proceed? Do you know the author of the wrapper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @hexylena
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not know the author of the wrapper
I will close it for now. it isn't enough of a priority, and I do not have time to move their tools into iuc/negotiate with them/rewrite their tool to not use a strange local option. |
If you need the tool we can work on that and try to get it into IUC for you. |
No description provided.