Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interactive_tools.yml #973

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Update interactive_tools.yml #973

merged 1 commit into from
Oct 31, 2023

Conversation

mira-miracoli
Copy link
Contributor

not 100% sure if the naming must be
interactive_tool or interactivetool

bgruening
bgruening reviewed Oct 30, 2023
View reviewed changes
files/galaxy/tpv/interactive_tools.yml
@@ -217,6 +217,8 @@ tools:
mem: 4
env:
HOME: /home/jovyan
interactive_tool_genenotebook:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks correct its the tool-id not the filename

bgruening
bgruening approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the test is failing.

mira-miracoli
mira-miracoli commented Oct 31, 2023
View reviewed changes
files/galaxy/tpv/interactive_tools.yml
@@ -217,6 +217,8 @@ tools:
mem: 4
env:
HOME: /home/jovyan
interactive_tool_genenotebook:
inherits: interactive_tool
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
inherits: interactive_tool
inherits: interactive_tool
cores: 1
mem: 4

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it needs more keys and just inheritance isn't enough?

@kysrpex
Copy link
Contributor

kysrpex commented Oct 31, 2023 •
edited
Loading

Clicking on "details" shows

galaxy.jobs.mapper.JobMappingException: Interactive tools require registration. Please log-in or register on https://usegalaxy.eu/login

because TPV dry-run runs as an anonymous user. This is the intended behavior (of the rule). At the moment I am not sure what the best solution is.

@kysrpex
Copy link
Contributor

kysrpex commented Oct 31, 2023 •
edited
Loading

Sorry I indeed know. I think a good solution is patching TPV so that if the fail: clause of a rule comes into effect, it still returns with exit code 0, as it is the expected behavior (for a dry run).

@mira-miracoli
Copy link
Contributor Author

OK so I think we can merge this?

kysrpex
kysrpex approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@kysrpex kysrpex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@bgruening bgruening merged commit 0e6fb54 into usegalaxy-eu:master Oct 31, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kysrpex kysrpex kysrpex approved these changes

@bgruening bgruening bgruening approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mira-miracoli @kysrpex @bgruening