Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect Human Cell Atlas subdomain to Single Cell subdomain #939

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Redirect Human Cell Atlas subdomain to Single Cell subdomain #939

merged 1 commit into from
Oct 10, 2023

Conversation

kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Oct 10, 2023

@kysrpex kysrpex self-assigned this Oct 10, 2023
sanjaysrikakulam
sanjaysrikakulam approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@sanjaysrikakulam sanjaysrikakulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect looks fine to me. However, I am unsure about the $scheme variable because we are forcing the use of HTTPS and asking it to listen to 443 anyway.

@kysrpex kysrpex mentioned this pull request Oct 10, 2023
Open
@kysrpex
Copy link
Contributor Author

kysrpex commented Oct 10, 2023 •
edited
Loading

The redirect looks fine to me. However, I am unsure about the $scheme variable because we are forcing the use of HTTPS and asking it to listen to 443 anyway.

I assume it simply has no effect. Anybody browsing HTTP should be redirected to HTTPS before they reach this.

@kysrpex kysrpex merged commit 4b77c4d into usegalaxy-eu:master Oct 10, 2023
2 checks passed
@kysrpex kysrpex deleted the human_cell_atlas_subdomain_redirect branch October 10, 2023 14:22
@sanjaysrikakulam
Copy link
Member

The redirect looks fine to me. However, I am unsure about the $scheme variable because we are forcing the use of HTTPS and asking it to listen to 443 anyway.

I assume it simply has no effect. Anybody browsing HTTP should be redirected to HTTPS before they reach this.

Yes, it has no effect, so I was unsure why it was added. Anyway, it's all good.

@kysrpex kysrpex linked an issue Oct 10, 2023 that may be closed by this pull request
Finalise single cell galaxy subdomain usegalaxy-eu/website#1154
Closed
6 tasks
@kysrpex kysrpex mentioned this pull request Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanjaysrikakulam sanjaysrikakulam sanjaysrikakulam approved these changes

Assignees

@kysrpex kysrpex

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalise single cell galaxy subdomain
2 participants
@kysrpex @sanjaysrikakulam