Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxDB enable FirewallD and set rules #1305

Merged

Conversation

mira-miracoli
Copy link
Contributor

No description provided.

Copy link
Member

@sanjaysrikakulam sanjaysrikakulam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@sj213 sj213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The role I had originally created was named ansible-fw-glxeu-generic, in this PR it is referred to as usegalaxy_eu.fw_glxeu_generic. Is this a typo or is this re-naming due to the specifics of the process of importing the role?

The rest looks ok by me.

@mira-miracoli
Copy link
Contributor Author

The role I had originally created was named ansible-fw-glxeu-generic, in this PR it is referred to as usegalaxy_eu.fw_glxeu_generic. Is this a typo or is this re-naming due to the specifics of the process of importing the role?

Not a typo, ansible usually uses a namespace, like usegalaxy_eu, since your role did not define it in the meta.yml I give it this name in the requirements.yml. I think it would work without but since all our roles use this namespace I thought it would look be more streamlined

@mira-miracoli mira-miracoli merged commit 513e9cc into usegalaxy-eu:master Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants