Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dorado_trimming feedback from testing #149

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

TomHarrop
Copy link
Collaborator

@TomHarrop TomHarrop commented Nov 6, 2024

@AnnaSyme I'm tracking changes for the dorado read trimmer here, let me know if there's anything else!

  • Don't allow custom primers with --no-trim-primers

@TomHarrop TomHarrop marked this pull request as draft November 6, 2024 03:29
@TomHarrop TomHarrop changed the title Trimming mods dorado_trimming feedback from testing Nov 6, 2024
@AnnaSyme
Copy link

AnnaSyme commented Nov 7, 2024

thanks @TomHarrop !

@AnnaSyme
Copy link

AnnaSyme commented Nov 7, 2024

@TomHarrop to convert the output bam file of trimmed reads to fastq, I'm using "samtoFastq", but it's giving me an error.
history: https://dev.gvl.org.au/u/annasyme/h/dorado
not sure if this is something to do with the dorado output itself, or something else. Edited to add: just saw on a different tool that Galaxy does not support bam files that are not coordinate sorted. Do you know if that's right.

@TomHarrop
Copy link
Collaborator Author

@AnnaSyme I've used Samtools fastx to get the reads out of the basecalling files. I think it should work for the trimming output too.

@AnnaSyme
Copy link

AnnaSyme commented Nov 8, 2024

@TomHarrop that looks good, yes. Edited rest of this message as I got confused between adapter removal and error correction!

@TomHarrop TomHarrop marked this pull request as ready for review November 11, 2024 03:03
@TomHarrop TomHarrop merged commit 42ce963 into usegalaxy-au:master Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants