Adding a Settings button #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Simplified the click callbacks (reduces the amount of IDs needed by the logic)
…rent files, each handling their own part of the landing page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI
It's added to the left of the query field:
This might be preparing the ground for #16 since I plan on not allowing Settings changes during scans. (It's possible that I'd then change the button's color to red and the icon would become an
X. Clicking the button in that state would abort the current scan.)The actual dialog is very similar to the Access Token one (indeed, I haven't added any options yet):
Features
The actual settings to be added are still a WIP. As it is, I plan on at least allowing users to:
ahead/behindstats to be calculated from either a "parent" or "source" repository (relates to Second Order Forks commit diff should relate to Source repo #18)ahead bycommits (the default is "anything > 0")To discuss ideas, please check out the following Discussion: #23.