Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: resolve env variables in headers when generating the code #3435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nook4sh
Copy link

@nook4sh nook4sh commented Nov 6, 2024

Description

Resolve the env variables in the headers when generating the code

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Linked to this issue : #1112

@nook4sh
Copy link
Author

nook4sh commented Nov 6, 2024

Hi master, I found the previous MR is outdated and has some conflicts. I want only to use the variables in the headers and I opened a new MR to fix it.
Could you help to review it? thank you! @helloanoop
cc @survivant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant