Reduce wasm binary size with cargo-xbuild & removing rlib crate-type
#33
Conversation
There was a problem hiding this comment.
Very nice! All in all the code looks clean.
Worked for Flipper and ERC20 but not so well for Delegator.
(File not found error.)
robrob@t460p~/p/i/e/delegator> ./build-all.sh
~/projects/ink/examples/delegator/accumulator ~/projects/ink/examples/delegator
[1/4] Collecting crate metadata
[2/4] Building cargo project
[3/4] Post processing wasm file
ERROR: Can't read from the file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
~/projects/ink/examples/delegator
~/projects/ink/examples/delegator/adder ~/projects/ink/examples/delegator
[1/4] Collecting crate metadata
[2/4] Building cargo project
[3/4] Post processing wasm file
ERROR: Can't read from the file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
~/projects/ink/examples/delegator
~/projects/ink/examples/delegator/subber ~/projects/ink/examples/delegator
[1/4] Collecting crate metadata
[2/4] Building cargo project
[3/4] Post processing wasm file
ERROR: Can't read from the file: Os { code: 2, kind: NotFound, message: "No such file or directory" }
~/projects/ink/examples/delegator
[1/4] Collecting crate metadata
[2/4] Building cargo project
[3/4] Post processing wasm file
[4/4] Optimizing wasm file
Original wasm size: 34K, Optimized: 14K
Your contract is ready. You can find it here:
/home/robrob/projects/ink/examples/delegator/target/delegator.wasm
ascjones
changed the title
|
Using Since I've also opened a PR to make it work with workspace configs (as our contract configs are): rust-osdev/cargo-xbuild#57 |
| &tmp_manifest_path.cargo_arg(), | ||
| &target_dir_arg, | ||
| "--release", | ||
| // "--no-default-features", // Breaks builds for MacOS (linker errors), we should investigate this issue asap! |
There was a problem hiding this comment.
I think --no-default-features is wrong anyway because this tool performs IO, so for example cannot be no_std.
| pub fn directory(&self) -> Option<&Path> { | ||
| let just_a_file_name = | ||
| self.path.iter().collect::<Vec<_>>() == vec![Path::new(MANIFEST_FILE)]; | ||
| if !just_a_file_name { |
Closes #32.
This PR significantly reduces the final wasm binary size by custom building rust
libcorewith thepanic_immediate_abortfeature which prevents panic strings and formatting code being included in the final executable.This is achieved using
cargo-xbuild.rlibcrate-typerlibis required to generate the metadata and also forink-as-dependency. However it also causes bloat in the final Wasm blob so it will be automatically removed if enabled when runningcargo contract build.Likewise if the
Cargo.tomldoesn't have therlibincrate-typesand the user runsgenerate-metadata, then that will also be added temporarily in order for build to succeed.A copy of the users
Cargo.tomlis made, amended as necessary and written to a temporary directory. Relative paths are rewritten to absolute paths.todo
User option to restore original Cargo.toml if process terminated(superseded)xbuildcargo clean(file not found)generate-metadatato work.cargo/configlinkargsAddSee Add default[profile.release]section, use provided values by default?[profile.release]values to Cargo.toml if not present #40--verboseand--quietargs,quietby default