Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rest of roundtrip fixes with CRC + CHANGELOG #91

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

robamu
Copy link
Contributor

@robamu robamu commented Nov 30, 2024

No description provided.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 88.52459% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.02%. Comparing base (9e71f68) to head (f83e48f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
spacepackets/cfdp/pdu/ack.py 66.66% 1 Missing ⚠️
spacepackets/cfdp/pdu/file_data.py 66.66% 1 Missing ⚠️
spacepackets/cfdp/pdu/finished.py 87.50% 1 Missing ⚠️
spacepackets/cfdp/pdu/keep_alive.py 66.66% 1 Missing ⚠️
spacepackets/cfdp/pdu/metadata.py 66.66% 1 Missing ⚠️
spacepackets/cfdp/pdu/nak.py 88.88% 1 Missing ⚠️
spacepackets/cfdp/pdu/prompt.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   96.06%   96.02%   -0.04%     
==========================================
  Files          92       92              
  Lines        7413     7454      +41     
==========================================
+ Hits         7121     7158      +37     
- Misses        292      296       +4     
Flag Coverage Δ
unittests 96.02% <88.52%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robamu robamu merged commit e70fb33 into main Nov 30, 2024
8 of 10 checks passed
@robamu robamu deleted the fix-roundtrip-with-crc-for-all-file-directives branch November 30, 2024 12:51
@robamu robamu added this to the vNext milestone Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant