-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI testing of unittests and linting #16
Conversation
Initially, add whitespace and pretty-print formatters.
@crangelsmith - I think that this is now ready to merge. This reproduces in GitHub Actions some of the tests that are run in Travis-CI in
Additionally, this PR adds linting rules via If/when merged, this PR would close #1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I see the pre-commit hooks checks are failing after updating main with PR #14 , anything I should do on that front?
Not for now thanks - I'm working on this and will let you know if there is anything. |
I have disabled a second test on CI, due to issue #20. In this case, I suspect (though haven't confirmed) that the problem is with the test code, not the CI or the production code. In order to complete this PR, I've opted to disable the test on CI, rather than delay implementing the rest of the CI/liniting checks. |
Initially, add whitespace and pretty-print formatters.