Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swapped request with got #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

swapped request with got #43

wants to merge 1 commit into from

Conversation

maikelmclauflin
Copy link

@maikelmclauflin maikelmclauflin commented Nov 27, 2020 •
edited
Loading

Description

upgraded request package, which has been deprecated: request/request#3142
used https://www.npmjs.com/package/got a close equivalent to reduce changes to api
cleaned up for newer versions of node (v14.15 lts)

yarn adds have yielded the following warning messages

warning @uphold/uphold-sdk-javascript > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning @uphold/uphold-sdk-javascript > [email protected]: request-promise has been deprecated because it extends the now deprecated request package, see https://github.com/request/request/issues/3142
warning @uphold/uphold-sdk-javascript > [email protected]: no longer maintained
warning @uphold/uphold-sdk-javascript > request > [email protected]: this library is no longer supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@maikelmclauflin