Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Protected Cards feature #216

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waldyrious
Copy link
Contributor

No description provided.

@waldyrious waldyrious self-assigned this Jul 2, 2021
@waldyrious waldyrious force-pushed the enhancement/protected-cards branch 2 times, most recently from 27da1a2 to 262ef2c Compare July 3, 2021 18:05
Copy link
Member

@fmfmartins fmfmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to apply the semantic linefeeds pattern to this document as well?

@waldyrious
Copy link
Contributor Author

Good point! Since it's a new document being added, we should take the opportunity to introduce it from the get-go with the line breaks. Thanks for the reminder, I'll update the PR shortly.

@waldyrious waldyrious force-pushed the enhancement/protected-cards branch from 262ef2c to 6b1d6d2 Compare July 5, 2021 13:56
@waldyrious
Copy link
Contributor Author

@fmfmartins PR updated. I've broken the longest lines in semantically meaningful places. There are still some relatively long lines left, but the structure of those sentences doesn't provide obvious places to break them further. We could improve the situation with additional work in rewording this content, but IMHO that work should be left to a subsequent improvement PR, so we can get this content out there (especially since these breaks aren't visible in the rendered docs anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants