Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workloadIdentitySettings ConfigMap for access to GKE fields #44

Merged
merged 3 commits into from
May 27, 2024

Conversation

markandersontrocme
Copy link
Member

@markandersontrocme markandersontrocme commented May 27, 2024

Description of your changes

In order to add external-dns support to platform-ref-upbound-spaces for GKE, we need access to some fields via ConfigMap:

  • GKE Project

Fixes #

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

In the output of the E2E I saw this:

   apiVersion: v1
   items:
   - apiVersion: kubernetes.crossplane.io/v1alpha2
     kind: Object
     metadata:
       annotations:
         crossplane.io/composition-resource-name: workloadIdentitySettings
         crossplane.io/external-create-pending: "2024-05-27T18:18:46Z"
         crossplane.io/external-create-succeeded: "2024-05-27T18:18:46Z"
         crossplane.io/external-name: configuration-gcp-gke-workload-identity-settings
         upjet.upbound.io/test: "true"
       creationTimestamp: "2024-05-27T18:11:20Z"
       finalizers:
       - finalizer.managedresource.crossplane.io
       generateName: configuration-gcp-gke-
       generation: 3
       labels:
         crossplane.io/claim-name: ""
         crossplane.io/claim-namespace: ""
         crossplane.io/composite: configuration-gcp-gke
       name: configuration-gcp-gke-workload-identity-settings
       ownerReferences:
       - apiVersion: gcp.platform.upbound.io/v1alpha1
         blockOwnerDeletion: true
         controller: true
         kind: XGKE
         name: configuration-gcp-gke
         uid: 8942a8a4-afe1-4c4a-acd9-bd8fd0fc9dbe
       resourceVersion: "3056"
       uid: b5967619-e1f6-4dca-8c8a-62dd9dc63c84
     spec:
       deletionPolicy: Orphan
       forProvider:
         manifest:
           apiVersion: v1
           data:
             gkeProject: official-provider-testing
           kind: ConfigMap
           metadata:
             name: configuration-gcp-gke-workload-identity-settings
             namespace: default
       managementPolicies:
       - '*'
       providerConfigRef:
         name: configuration-gcp-gke
       readiness:
         policy: SuccessfulCreate
     status:
       atProvider:
         manifest:
           apiVersion: v1
           data:
             gkeProject: official-provider-testing
           kind: ConfigMap
           metadata:
             annotations:
               kubectl.kubernetes.io/last-applied-configuration: '***"apiVersion":"v1","data":***"gkeProject":"official-provider-testing"***,"kind":"ConfigMap","metadata":***"name":"configuration-gcp-gke-workload-identity-settings","namespace":"default"***'
             creationTimestamp: "2024-05-27T18:18:46Z"
             managedFields:
             - apiVersion: v1
               fieldsType: FieldsV1
               fieldsV1:
                 f:data:
                   .: ***
                   f:gkeProject: ***
                 f:metadata:
                   f:annotations:
                     .: ***
                     f:kubectl.kubernetes.io/last-applied-configuration: ***
               manager: crossplane-kubernetes-provider
               operation: Update
               time: "2024-05-27T18:18:46Z"
             name: configuration-gcp-gke-workload-identity-settings
             namespace: default
             resourceVersion: "2115"
             uid: 50e8a17f-852e-4f68-bbbb-9f72ed22eb95
       conditions:
       - lastTransitionTime: "2024-05-27T18:18:46Z"
         reason: ReconcileSuccess
         status: "True"
         type: Synced
       - lastTransitionTime: "2024-05-27T18:18:46Z"
         reason: Available
         status: "True"
         type: Ready

@haarchri
Copy link
Member

/test-examples

@markandersontrocme
Copy link
Member Author

/test-examples

@markandersontrocme
Copy link
Member Author

/test-examples

1 similar comment
@markandersontrocme
Copy link
Member Author

/test-examples

@haarchri haarchri merged commit a4f90cf into main May 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants