Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-983] - Add gas estimations for multicall domain transfer #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DeRain
Copy link
Contributor

@DeRain DeRain commented May 24, 2023

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager or ProxyReader contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager or ProxyReader contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@DeRain DeRain requested a review from a team May 24, 2023 10:53
@github-actions
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
MintingManager 13.703 0
ProxyReader 11.51 0
UNSRegistry 20.129 0

@codecov-commenter
Copy link

Codecov Report

Merging #272 (68d1d72) into main (bc79cc1) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          28       28           
  Lines         867      867           
  Branches      183      183           
=======================================
  Hits          851      851           
  Misses         16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants