fix: unbreak iOS CI build and enable x86 Android targets #14
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Johennes
approved these changes
Dec 18, 2024
| @@ -33,6 +33,9 @@ jobs: | |||
|
|
|||
| - name: Generate | |||
| run: | | |||
| # Disabling NEON fixes linker error, see | |||
| # https://github.com/unomed-dev/react-native-matrix-sdk/issues/12 | |||
| export CARGO_FEATURE_NO_NEON=1 | |||
There was a problem hiding this comment.
This comment made me think that we should probably force the reldbg profile during building instead. However, uniffi-bindgen-react-native only supports release and debug right now. So I think this is fine for now.
There was a problem hiding this comment.
Have logged jhugman/uniffi-bindgen-react-native#190 upstream to allow specifying the profile in future.
Johennes
changed the title
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #12 and adds a x86 build for Android.