-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support variable axes for google #35
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
220fe83
feat: add support for variable axes
qwerzl cbcab68
Merge branch 'main' into feat/variable-axes
qwerzl d40c01a
chore: mark `variableAxis` experimental
qwerzl ba034c2
chore: move `variableAxis` configuration to provider option of `google`
qwerzl 8d44d21
Merge branch 'main' into feat/variable-axes
qwerzl 83b34c7
fix: handle hinted types
danielroe 2949ab8
test: add test
qwerzl 169cf90
fix: also extract variable styles from CSS
qwerzl 0645c7b
Revert "fix: also extract variable styles from CSS"
qwerzl 80a4860
test: update testing condition for styles
qwerzl b12621d
Merge branch 'main' into feat/variable-axes
qwerzl 2f61128
fix: change variable axis notation
qwerzl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make more sense for the format to be:
it feels like the
..
joining is an implementation detail for google that we can add in...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danielroe Resolved. Sorry for the delay!