Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for using undici dispatcher #389

Merged
merged 2 commits into from
May 16, 2024
Merged

docs: add docs for using undici dispatcher #389

merged 2 commits into from
May 16, 2024

Conversation

blowsie
Copy link
Contributor

@blowsie blowsie commented Apr 24, 2024

πŸ”— Linked issue

#379, #215, #316

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

agent setting only applies to older versions of node.
As of version 18 node fetch is native and depends on undici, which uses a dispatcher option instead

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@blowsie
Copy link
Contributor Author

blowsie commented Apr 24, 2024

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title docs(README): improve https and proxy agent documentation docs: add docs for using undici dispatcher May 16, 2024
@pi0 pi0 merged commit c24c9a3 into unjs:main May 16, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants