Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(resolver): remove intermediate pcall util #230

Merged
merged 5 commits into from
Feb 21, 2024
Merged

perf(resolver): remove intermediate pcall util #230

merged 5 commits into from
Feb 21, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 21, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Remove intermediate pcall util for async functions. it was mainly to reduce stacktrace size but seems really uncessary.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 changed the title perf/pcall perf(resolver): remove intermediate pcall util Feb 21, 2024
@pi0 pi0 merged commit 4469e7b into main Feb 21, 2024
2 checks passed
@pi0 pi0 deleted the perf/pcall branch February 21, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant