test: package.json eol is removed #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
|
Thanks for the PR. As for the tests, preserving EOL is responsibility scope of pkg-types therefore need to be tested there (otherwise we overcomplicate and slow down tests) |
|
Yes, no need to duplicate tests. At first, I was thinking that changelogen was the issue but while I was writing tests I discover that pkg-types was the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #170
Hello 👋,
It seems that the trailing newline is remove when changelogen touch the version. This is a problem because it can break format checking tools like
prettieroreslint.I add tests that fails but it seems that this bug comes from pkg-types.
To fix this issue, I simply update pkg-types to 1.1.3 since Pooya fixed this in unjs/pkg-types#175