Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pm-x generator #11

Merged
merged 7 commits into from
Feb 7, 2024
Merged

feat: pm-x generator #11

merged 7 commits into from
Feb 7, 2024

Conversation

uncenter
Copy link
Collaborator

@uncenter uncenter commented Feb 7, 2024

Oops, looks like renaming the branch causes the PR to be closed... live and learn I guess.

πŸ”— Linked issue

Closes #5.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adds a pm-x generator as discussed in #5. Implementation based on pm-install generator.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@cpreston321
Copy link
Member

@uncenter update main README.md πŸ™πŸΌ?

@uncenter
Copy link
Collaborator Author

uncenter commented Feb 7, 2024

@uncenter update main README.md πŸ™πŸΌ?

Right yeah I forgot ahah. Should be good now.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (added some refactors and also ideas mainly to try!)

@pi0 pi0 merged commit 0b59d4d into unjs:main Feb 7, 2024
2 checks passed
@uncenter
Copy link
Collaborator Author

uncenter commented Feb 7, 2024

Sweet, changes looks good!

@uncenter uncenter deleted the feat/pm-x-generator branch February 7, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package manager command generators
3 participants