add try/catch to permitAndStake, permitAndStakeMore
#85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildmolasses
requested review from
alexkeating and
apbendi
and removed request for
alexkeating
wildmolasses
force-pushed
the
04-09-permit_trycatch
branch
from
1e8c146 to
ac21f7c
Compare
alexkeating
approved these changes
Apr 9, 2024
alexkeating
previously requested changes
Apr 9, 2024
|
Fixed the tests, let me know if you think they satisfy |
wildmolasses
force-pushed
the
04-09-permit_trycatch
branch
from
95cbe73 to
a485c90
Compare
|
Coverage after merging 04-09-permit_trycatch into main will be
Coverage Report
|
|||||||||||||||||||||||||
alexkeating
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #80