Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dust rounding on claimReward #83

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Dust rounding on claimReward #83

merged 2 commits into from
Apr 10, 2024

Conversation

wildmolasses
Copy link
Collaborator

@wildmolasses wildmolasses commented Apr 9, 2024

closes #81

@wildmolasses wildmolasses marked this pull request as ready for review April 9, 2024 15:46
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think a comment would be helpful.

src/UniStaker.sol Show resolved Hide resolved
@wildmolasses wildmolasses requested a review from apbendi April 10, 2024 15:13
Copy link

Coverage after merging 04-09-dust_rounding into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol99.52%96.15%100%100%670
   V3FactoryOwner.sol100%100%100%100%

Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@apbendi apbendi merged commit c8a2d84 into main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate dust rounding
3 participants