Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change Deposit.balance type to uint96 #76

Merged
merged 3 commits into from
Apr 10, 2024
Merged

change Deposit.balance type to uint96 #76

merged 3 commits into from
Apr 10, 2024

Conversation

wildmolasses
Copy link
Collaborator

@wildmolasses wildmolasses commented Apr 5, 2024 •
edited
Loading

closes #79

@wildmolasses wildmolasses force-pushed the 04-05-change_deposit_amount_to_uint96 branch from 5edfe29 to 53e4fc0 Compare April 5, 2024 17:18
@wildmolasses wildmolasses changed the title change Deposit.amount type to uint96 change Deposit.balance type to uint96 Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Coverage after merging 04-05-change_deposit_amount_to_uint96 into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol99.52%96.15%100%100%670
   V3FactoryOwner.sol100%100%100%100%

@wildmolasses wildmolasses requested a review from alexkeating April 9, 2024 16:15
@wildmolasses wildmolasses marked this pull request as ready for review April 9, 2024 16:15
@wildmolasses wildmolasses requested a review from apbendi April 9, 2024 16:15
apbendi
apbendi approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @wildmolasses, thanks!

@apbendi apbendi merged commit de35d2d into main Apr 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkeating alexkeating alexkeating approved these changes

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate deposit.balance type change to uint96
3 participants
@wildmolasses @apbendi @alexkeating