Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to invalidate nonce #72

Merged
merged 10 commits into from
Mar 26, 2024
Merged

Add function to invalidate nonce #72

merged 10 commits into from
Mar 26, 2024

Conversation

alexkeating
Copy link
Collaborator

Description

  • Add function that allows a user to invalidate their nonce

Closes #66

@alexkeating alexkeating requested a review from apbendi March 22, 2024 13:55
wildmolasses
wildmolasses reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments, otherwise lgtm

test/UniStaker.t.sol Outdated Show resolved Hide resolved
test/UniStaker.t.sol Outdated Show resolved Hide resolved
test/UniStaker.t.sol Outdated Show resolved Hide resolved
test/UniStaker.t.sol Outdated Show resolved Hide resolved
@alexkeating alexkeating force-pushed the feature/invalidate-nonce branch from 28c8bf7 to 5a10cd2 Compare March 22, 2024 15:50
apbendi
apbendi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@apbendi apbendi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test naming nits, but otherwise looks good @alexkeating

test/UniStaker.t.sol Outdated Show resolved Hide resolved
test/UniStaker.t.sol Outdated Show resolved Hide resolved
wildmolasses
wildmolasses approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@wildmolasses wildmolasses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apbendi apbendi force-pushed the feature/invalidate-nonce branch from 335abf9 to 5d0c4ee Compare March 26, 2024 14:32
@github-actions GitHub Actions
Copy link

Coverage after merging feature/invalidate-nonce into main will be

100.00%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   UniStaker.sol99.50%95.83%100%100%632
   V3FactoryOwner.sol100%100%100%100%

@apbendi apbendi merged commit 0a912ff into main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wildmolasses wildmolasses wildmolasses approved these changes

@apbendi apbendi apbendi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an external method to allow the caller to invalidate nonce
3 participants
@alexkeating @apbendi @wildmolasses