Invariant test suite #35
Conversation
wildmolasses
force-pushed
the
01-25-Start_Invariant_Testing
branch
2 times, most recently
from
20797c5 to
7a6f026
Compare
wildmolasses
force-pushed
the
01-25-Start_Invariant_Testing
branch
3 times, most recently
from
c077aa4 to
8db1191
Compare
wildmolasses
force-pushed
the
01-25-Start_Invariant_Testing
branch
from
53e0558 to
33cedd0
Compare
| @@ -0,0 +1,68 @@ | |||
| # Invariant Suite | |||
There was a problem hiding this comment.
Is the detail here appropriate for public consumption, or do we want to cull it?
There was a problem hiding this comment.
The info is good, it may be clearer if the unimplemented actions are removed
There was a problem hiding this comment.
chatted a bit with @apbendi, going to keep them around for now
test/UniStaker.invariants.t.sol
Outdated
| address rewardsNotifier; | ||
|
|
||
| function setUp() public { | ||
| // deploy UniStaker |
There was a problem hiding this comment.
Comment should probably be removed or moved to line 28
| mapping(address => bool) saved; | ||
| } | ||
|
|
||
| library LibAddressSet { |
There was a problem hiding this comment.
Was this taken from the article? It may be good to add a comment and link to where this came from.
There was a problem hiding this comment.
added a comment, thanks
test/helpers/UniStaker.handler.sol
Outdated
| address public admin; | ||
|
|
||
| // actors, deposit state | ||
| address internal currentActor; |
There was a problem hiding this comment.
Nit: should this have an underscore?
There was a problem hiding this comment.
good call, changed!
test/helpers/UniStaker.handler.sol
Outdated
| ghost_rewardsNotified += _amount; | ||
| } | ||
|
|
||
| // TODO: distinguish between valid and invalid stake |
There was a problem hiding this comment.
Are this and the TODO below still todos?
There was a problem hiding this comment.
yes -- invalid stake is not yet included in harness, nor is invalid withdraw
There was a problem hiding this comment.
Ah okay it may be good to move these to issues then
foundry.toml
Outdated
| fail_on_revert = false | ||
| include_push_bytes = true | ||
| include_storage = true | ||
| runs = 100 |
There was a problem hiding this comment.
It may be worth bumping some of these for CI runs.
There was a problem hiding this comment.
i'm happy to do that. what values would be good?
There was a problem hiding this comment.
Maybe bump them back to the default values for runs and depth
wildmolasses
force-pushed
the
01-25-Start_Invariant_Testing
branch
from
ccc3fa3 to
7fe1451
Compare
Co-authored-by: Alexander Keating <[email protected]>
apbendi
force-pushed
the
01-25-Start_Invariant_Testing
branch
from
cf66d54 to
c6e46f4
Compare
|
Coverage after merging 01-25-Start_Invariant_Testing into main will be
Coverage Report
|
|||||||||||||||||||||||||
Resolves #11
This suite should not be considered complete. It's a solid base from which to expand, and tests the invariants listed in #11 as well as others.