Make changes based on feedback

script/ProposeFactorySetOwner.s.sol

@@ -12,6 +12,7 @@ contract ProposeFactorySetOwner is Script, DeployInput {
   address _proposer =
     vm.envOr("PROPOSER_ADDRESS", address(0x0459f41c5f09BF678D9C07331894dE31d8C22255));
 
+  /// @param _newV3FactoryOwner The new factory owner which should have be the recently deployed.
   function proposeFactoryOwnerChangeOnGovernor(address _newV3FactoryOwner)
     internal
     returns (uint256 _proposalId)

script/ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools.sol

@@ -0,0 +1,19 @@
+// SPDX-License-Identifier: AGPL-3.0-only
+pragma solidity ^0.8.23;
+
+import {Script} from "forge-std/Script.sol";
+
+import {DeployInput} from "script/DeployInput.sol";
+import {GovernorBravoDelegate} from "script/interfaces/GovernorBravoInterfaces.sol";
+import {ProposeSetProtocolFeeOnPools} from "script/ProposeSetProtocolFeeOnPools.s.sol";
+
+contract ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools is ProposeSetProtocolFeeOnPools {
+  PoolFeeSettings[] public poolFeeSettings;
+
+  function getPoolFeeSettings() internal override returns (PoolFeeSettings[] memory) {
+    poolFeeSettings.push(PoolFeeSettings(WBTC_WETH_3000_POOL, 10, 10));
+    poolFeeSettings.push(PoolFeeSettings(DAI_WETH_3000_POOL, 10, 10));
+    poolFeeSettings.push(PoolFeeSettings(DAI_USDC_100_POOL, 10, 10));
+    return poolFeeSettings;
+  }
+}

script/ProposeSetProtocolFeeOnPools.s.sol

@@ -17,7 +17,7 @@ abstract contract ProposeSetProtocolFeeOnPools is Script, DeployInput {
   string[] public signatures;
   bytes[] public calldatas;
 
-  struct PoolFees {
+  struct PoolFeeSettings {
     address pool;
     uint8 feeProtocol0;
     uint8 feeProtocol1;
@@ -35,7 +35,7 @@ abstract contract ProposeSetProtocolFeeOnPools is Script, DeployInput {
     calldatas.push(abi.encode(_pool, _feeProtocol0, _feeProtocol1));
   }
 
-  function newPoolFeeSettings() internal virtual returns (PoolFees[] memory);
+  function getPoolFeeSettings() internal virtual returns (PoolFeeSettings[] memory);
 
   function propose() internal returns (uint256 _proposalId) {
     return GOVERNOR.propose(
@@ -58,10 +58,13 @@ abstract contract ProposeSetProtocolFeeOnPools is Script, DeployInput {
     vm.rememberKey(_proposerKey);
 
     vm.startBroadcast(_proposer);
-    PoolFees[] memory poolFees = newPoolFeeSettings();
-    for (uint256 i = 0; i < poolFees.length; i++) {
+    PoolFeeSettings[] memory poolFeeSettings = getPoolFeeSettings();
+    for (uint256 i = 0; i < poolFeeSettings.length; i++) {
       pushFeeSettingToProposalCalldata(
-        _newV3FactoryOwner, poolFees[i].pool, poolFees[i].feeProtocol0, poolFees[i].feeProtocol1
+        _newV3FactoryOwner,
+        poolFeeSettings[i].pool,
+        poolFeeSettings[i].feeProtocol0,
+        poolFeeSettings[i].feeProtocol1
       );
     }
 

test/helpers/ProposalTest.sol

@@ -6,7 +6,7 @@ import {Test} from "forge-std/Test.sol";
 import {Deploy} from "script/Deploy.s.sol";
 import {DeployInput} from "script/DeployInput.sol";
 import {ProposeFactorySetOwner} from "script/ProposeFactorySetOwner.s.sol";
-import {ProposeSetProtocolFeeOnFirstPools} from "script/ProposeSetProtocolFeeOnFirstPools.sol";
+import {ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools} from "script/ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools.sol";
 import {Constants} from "test/helpers/Constants.sol";
 import {GovernorBravoDelegate} from "script/interfaces/GovernorBravoInterfaces.sol";
 import {V3FactoryOwner} from "src/V3FactoryOwner.sol";
@@ -62,7 +62,7 @@ abstract contract ProposalTest is Test, DeployInput, Constants {
   }
 
   function _proposePoolFee() internal {
-    ProposeSetProtocolFeeOnFirstPools _proposeFeeScript = new ProposeSetProtocolFeeOnFirstPools();
+    ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools _proposeFeeScript = new ProposeNewFeesOnWbtcWethDaiWethAndDaiUsdcPools();
     setFeeProposalId = _proposeFeeScript.run(address(v3FactoryOwner));
   }