Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Dockerfile for the main nivlheim (api) image #181

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Add a Dockerfile for the main nivlheim (api) image #181

merged 8 commits into from
Sep 26, 2022

Conversation

mapemapemape
Copy link
Contributor

No description provided.

@mapemapemape mapemapemape self-assigned this Sep 8, 2022
@oyvindhagberg
Copy link
Contributor

Har lyst til å legge inn en ci.yaml i denne branchen som bruker den nye Dockerfilen til å bygge image istedetfor Guix, se hva som eventuelt brekker da, og fikse det opp. Skal se om jeg får tid til i løpet av uka.

@oyvindhagberg
Copy link
Contributor

Må også legge inn go.mod og go.sum

@mapemapemape
Copy link
Contributor Author

go.mod og go.sum er lagt inn

@oyvindhagberg
Copy link
Contributor

oyvindhagberg commented Sep 16, 2022 •
edited
Loading

Kommer til å rebase branchen og trekke sammen noen commits når alt er klart ellers
Oppdatering: Har gjort det nå

@oyvindhagberg oyvindhagberg marked this pull request as draft September 16, 2022 11:30
@oyvindhagberg oyvindhagberg marked this pull request as ready for review September 16, 2022 13:14
mapemapemape and others added 5 commits September 16, 2022 15:49
@mapemapemape @oyvindhagberg
Add a Dockerfile for the main nivlheim (api) image
a2285eb
@mapemapemape @oyvindhagberg
Add go.mod and go.sum for building the api docker image
98c0615
@oyvindhagberg
Fix the way the utility package is imported
e37b2f4 
Discovered that Go used a separate, downloaded copy of the utility
package when compiling, instead of using local files.
What we want is for it to use the files in the utility subdirectory.
Turns out, we (I) had been importing the utility package the wrong way
this whole time.
This commit fixes go.mod and every Go file that imports the package.
@oyvindhagberg
Some changes from "go fmt", mostly whitespace
ab94403
@oyvindhagberg
Build the server image with Docker instead of Guix
8b233d5 
Also fix "COPY" statements in api_Dockerfile
@oyvindhagberg oyvindhagberg marked this pull request as draft September 16, 2022 14:31
@oyvindhagberg
Copy link
Contributor

Feilmelding på https://nivlheim-test.uio.no ved innlogging:
Post "https://auth.dataporten.no/oauth/token": x509: certificate signed by unknown authority
Må finne ut av det før vi kan flette denne inn i master.

@oyvindhagberg
Copy link
Contributor

Feilmelding på https://nivlheim-test.uio.no ved innlogging: Post "https://auth.dataporten.no/oauth/token": x509: certificate signed by unknown authority Må finne ut av det før vi kan flette denne inn i master.

Løses ved å installere pakken ca-certificates under bygging av containerbildet.

@oyvindhagberg oyvindhagberg marked this pull request as ready for review September 23, 2022 12:13
@oyvindhagberg oyvindhagberg merged commit 7c30fe2 into master Sep 26, 2022
@oyvindhagberg oyvindhagberg deleted the api-dockerfile branch September 26, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oyvindhagberg oyvindhagberg oyvindhagberg approved these changes

@mbakke mbakke Awaiting requested review from mbakke

Assignees

@oyvindhagberg oyvindhagberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapemapemape @oyvindhagberg