Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: Remove top level heading check #261

Merged

Conversation

StefanJum
Copy link
Member

The linter checks if the first line in the file is a top-level heading.
This does not work with markdown files that are included in other files, not used as such (e.g. files under hackathons/sessions/*/content/).

@StefanJum StefanJum added the enhancement New feature or request label Jun 18, 2023
@StefanJum StefanJum requested a review from RaduNichita June 18, 2023 12:50
Copy link
Contributor

@RaduNichita RaduNichita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my side!

Reviewed-by: Radu Nichita [email protected]

@razvand
Copy link
Contributor

razvand commented Aug 19, 2024

@StefanJum , could you please rebase the PR?

The linter checks if the first line in the file is a top-level heading.
This does not work with markdown files that are included in other files,
not used as such (e.g. files under `hackathons/sessions/*/content/`).

Signed-off-by: Stefan Jumarea <[email protected]>
@StefanJum StefanJum force-pushed the StefanJum/linter-ignore-top-line branch from 8da451a to 3de935e Compare December 10, 2024 11:08
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved-by: Razvan Deaconescu [email protected]

@razvand razvand merged commit 314cc92 into unikraft:main Dec 19, 2024
2 checks passed
@razvand razvand deleted the StefanJum/linter-ignore-top-line branch December 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants