[US-234] Update form example to add a submit button #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ace
force-pushed
the
us-234-form-submission-example
branch
from
46c4c73 to
5137e94
Compare
sampila
requested changes
Jan 8, 2024
|
@sampila is there a particular reason for that? Since I think the submit button is related with form. But if there's a good reason for it then I'm okay to separate the example. |
|
Yeah might be good to separate. The other one is just focused on adding some basic things to the form but then this one adds the submit functionality which I am not sure if is very commonly used. |
|
understood, I'll update the PR then. Thanks for the input |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.