Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

Make Language data exportable #633

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vleong2332
Copy link
Contributor

@vleong2332 vleong2332 commented Sep 15, 2016

Export may not work properly in prod because it took longer than 30 seconds to complete.


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.183% when pulling 0acdf2a on WycliffeAssociates:language-export-admin into cd3b6a9 on unfoldingWord-dev:develop.

@phillip-hopper
Copy link
Contributor

If it's a long running function, perhaps you should kick off another process that creates the export file, and return a page that tells the user he will receive an email with a link when the export is complete.


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@phillip-hopper
Copy link
Contributor

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


td/admin.py, line 55 at r1 (raw file):

class LanguageAdmin(EntryTrackingAdmin, ImportExportModelAdmin):

See comment above.


Comments from Reviewable

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants