Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to linking and other fixes #46

Merged
merged 11 commits into from
May 16, 2017
Merged

Updates to linking and other fixes #46

merged 11 commits into from
May 16, 2017

Conversation

da1nerd
Copy link
Contributor

@da1nerd da1nerd commented May 5, 2017

This fixes #44, part of #43, and #38

@da1nerd
Copy link
Contributor Author

da1nerd commented May 6, 2017

Ok this now ready for review. #19 and #43 have questions that could potentially be included in this as well.

@da1nerd da1nerd changed the title Updates to linking and other minor fixes Updates to linking and other fixes May 6, 2017
phillip-hopper
phillip-hopper approved these changes May 10, 2017
View reviewed changes
Copy link

@phillip-hopper phillip-hopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PhotoNomad0 PhotoNomad0 merged commit 4cb7a8d into unfoldingWord-dev:master May 16, 2017
@da1nerd da1nerd deleted the updates branch May 16, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillip-hopper phillip-hopper phillip-hopper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use GLOB format in links
3 participants
@da1nerd @phillip-hopper @PhotoNomad0