Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to examples for each container type #19

Closed
5 of 8 tasks
jag3773 opened this issue Jan 12, 2017 · 4 comments · Fixed by #48
Closed
5 of 8 tasks

Link to examples for each container type #19

jag3773 opened this issue Jan 12, 2017 · 4 comments · Fixed by #48
Labels

Comments

@jag3773
Copy link
Contributor

jag3773 commented Jan 12, 2017

We need to link to pristine examples of what each container type looks like in Gogs.

  • image
  • audio
  • video
  • book
  • help
  • dictionary
  • manual
  • bundle
@da1nerd
Copy link
Contributor

da1nerd commented Jan 27, 2017

This will be a book example https://git.door43.org/Door43/en-obs/pulls/8

@da1nerd da1nerd self-assigned this May 2, 2017
@da1nerd
Copy link
Contributor

da1nerd commented May 4, 2017

Note: if we implement #42 we may deprecate the image audio and video container types.

@jag3773 after reviewing this I think we can safely deprecate the image, audio, and video container types now for a number of reasons.

  1. we no longer need a container type to determine what format of content is provided. e.g. We either use the format field in the manifest or, if we follow through with Remove format definition from RC manifest #42, the file extension. This information is given it the catalog like "format":"application/zip; type=audio content=audio/mp3 conformsto=rc0.2".
  2. These types are already structured like the book type anyway.
  3. If we follow through with Remove format definition from RC manifest #42 this would open up the possibility of providing media for any container type.

@da1nerd da1nerd removed their assignment May 4, 2017
@jag3773
Copy link
Contributor Author

jag3773 commented May 17, 2017

@neutrinog Sounds good.

@da1nerd
Copy link
Contributor

da1nerd commented May 17, 2017

I removed the audio, video, and image types.

@da1nerd da1nerd mentioned this issue May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants