set minimun goal const #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmanuelAR
requested changes
Nov 3, 2024
| @@ -5,4 +5,5 @@ pub mod FundConstants { | |||
| pub const UP_VOTES_NEEDED: u32 = 100; | |||
| pub const INITIAL_UP_VOTES: u32 = 0; | |||
| pub const INITIAL_GOAL: u256 = 0; | |||
| pub const MINIMUM_GOAL: u256 = 500_u256; | |||
There was a problem hiding this comment.
set this pub const MINIMUM_GOAL: u256 = 500;
contracts/src/fundManager.cairo
Outdated
| @@ -33,6 +36,7 @@ pub mod FundManager { | |||
| current_id: u128, | |||
| funds: LegacyMap::<u128, ContractAddress>, | |||
| fund_class_hash: ClassHash, | |||
| minimum_goal_state: u256, | |||
There was a problem hiding this comment.
You don't have to add the constant in the constructor
contracts/src/fundManager.cairo
Outdated
| @@ -71,6 +76,7 @@ pub mod FundManager { | |||
| #[abi(embed_v0)] | |||
| impl FundManagerImpl of super::IFundManager<ContractState> { | |||
| fn newFund(ref self: ContractState, name: felt252, goal: u256) { | |||
| assert(goal >= self.minimum_goal_state.read(), 'Goal must be at least 500'); | |||
There was a problem hiding this comment.
you have to call the constant here like this example FundConstants::INITIAL_UP_VOTES
EmmanuelAR
requested changes
Nov 3, 2024
contracts/src/fundManager.cairo
Outdated
| @@ -22,6 +22,9 @@ pub mod FundManager { | |||
| use starknet::class_hash::ClassHash; | |||
| use starknet::get_caller_address; | |||
| use openzeppelin::utils::serde::SerializedAppend; | |||
| use gostarkme::constants::{ | |||
There was a problem hiding this comment.
use this please
use gostarkme::constants::{ funds::{fund_constants::FundConstants}, };
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Changes description
Describe what your changes will do and any TODOs there might be in the future related to the issue you are closing.
In the constants file create the new constant with the minimum required, import that constant to the fundManager file with its storage and constructor and use it
Current output
Give evidence like screenshots of what your job looks like.
Time spent breakdown
4 hours
Give a breakdown on the time you used to solve the issue you are closing.
Comments
Any other details you might want to share.