Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] Adding donator contract #15

Closed
wants to merge 4 commits into from
Closed

[#7] Adding donator contract #15

wants to merge 4 commits into from

Conversation

EmmanuelAR
Copy link
Collaborator

Captura de pantalla 2024-08-06 a la(s) 4 35 39 p  m #7

@EmmanuelAR EmmanuelAR requested a review from adrianvrj August 6, 2024 22:36
@EmmanuelAR EmmanuelAR self-assigned this Aug 6, 2024
adrianvrj
adrianvrj requested changes Aug 7, 2024
View reviewed changes
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a level up logic where the user can only level up after reaching certain amount of donations, that way we prevent user from calling the level up function without any restrictions

@EmmanuelAR
Copy link
Collaborator Author

okk thanks, on it @adrianvrj

@EmmanuelAR EmmanuelAR marked this pull request as ready for review August 13, 2024 01:58
@adrianvrj adrianvrj self-assigned this Aug 13, 2024
This was linked to issues Aug 13, 2024
Add Donator contract #7
Closed
Add enums for errors and msg handlings #22
Closed
@EmmanuelAR
Copy link
Collaborator Author

This pr with be close and open a new one cuz some changes surge in today meetings

@EmmanuelAR EmmanuelAR closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj requested changes

Assignees

@EmmanuelAR EmmanuelAR

@adrianvrj adrianvrj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add enums for errors and msg handlings Add Donator contract
2 participants
@EmmanuelAR @adrianvrj