Initial implementation: product, product_item, reservation #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And move page.up endpoint therein.
Introduce a product factory for easier testing of existing products.
And the product id as via a json response.
Allows create and update. Here I split the attributes between Product and ProductItem such that Product is a category, always having one or more ProductItem. In the case of fungible items, the ProductItem is conceptually a variant of the product. In the case of non-fungible items, each ProductItem represents a separate item, and has a amount_in_stock value of 1.
Note this is a partial implementation: only create and destroy/cancel are supported, and only the current request is considered against the total amount on stock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bitcoinstore/api for endpoints, which are in the style of nested restful resources.
See docs and test for descriptions. To accommodate fungible vs. non-fungible products, the product is represented as a type of item, with the items used to represent both non-fungible items and fungible items, which can be of a single type or several variants.
For reservations, the item is locked on a row basis, and aggregate counts are maintained on the item.