Move heads of terms review into new layout #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamineskola
force-pushed
the
review-heads-of-terms
branch
4 times, most recently
from
bf26dae
to
16910b7
Compare
EGiataganas
reviewed
Nov 25, 2024
app/controllers/planning_applications/review/heads_of_terms_controller.rb
Show resolved
Hide resolved
EGiataganas
reviewed
Nov 25, 2024
app/views/planning_applications/review/heads_of_terms/_form.html.erb
Outdated
Show resolved
Hide resolved
benjamineskola
force-pushed
the
review-heads-of-terms
branch
from
16910b7
to
8aec63a
Compare
EGiataganas
approved these changes
Nov 25, 2024
benbaumann95
approved these changes
Nov 25, 2024
app/views/planning_applications/review/tasks/_review_conditions.html.erb
Outdated
Show resolved
Hide resolved
benbaumann95
requested changes
Nov 25, 2024
app/views/planning_applications/review/tasks/_review_conditions.html.erb
Outdated
Show resolved
Hide resolved
benjamineskola
force-pushed
the
review-heads-of-terms
branch
2 times, most recently
from
5a66429
to
3adefdf
Compare
benbaumann95
approved these changes
Nov 26, 2024
benjamineskola
force-pushed
the
review-heads-of-terms
branch
from
8e2620c
to
9d59302
Compare
EGiataganas
reviewed
Nov 26, 2024
| def update | ||
| respond_to do |format| | ||
| format.html do | ||
| if heads_of_term.update(review_params) | ||
| redirect_to planning_application_review_tasks_path(@planning_application), | ||
| notice: I18n.t("review.heads_of_terms.update.success") | ||
| else | ||
| render :show |
There was a problem hiding this comment.
could we apply same pattern?
change the
def heads_of_term
@planning_application.heads_of_term
endto
def set_heads_of_term
@heads_of_term = @planning_application.heads_of_term
endhappy to do it as additional PR if you want
so this would be
flash.now[:alert] = @heads_of_term.errors.messages.values.flatten.join(", ")There was a problem hiding this comment.
I don't really like the pattern of using a method to set an instance variable and then using the instance variable. I think it's preferable to use a method call where possible.
It makes sense for variables that will be used in a view, because instance variables are needed for that, methods aren't accessible from the view. But for cases like this I don't think it makes sense.
benjamineskola
force-pushed
the
review-heads-of-terms
branch
from
9d59302
to
6a21841
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Move heads of terms review into new review layout.
Story Link
https://trello.com/c/Ae4hmaT1/26-redesign-of-review-heads-of-terms
Screenshots
If you have made changes to the frontend please add screenshots