Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show ownership certificates #186

Merged
merged 7 commits into from
Jan 8, 2024
Merged

Show ownership certificates #186

merged 7 commits into from
Jan 8, 2024

Conversation

cdccollins
Copy link
Contributor

@cdccollins cdccollins commented Dec 14, 2023 •
edited
Loading

@cdccollins cdccollins force-pushed the ownership-certificate branch 30 times, most recently from 683c28c to 730cb46 Compare December 19, 2023 16:20
@cdccollins cdccollins force-pushed the ownership-certificate branch 9 times, most recently from 7bcc08d to ca55f71 Compare December 19, 2023 17:13
@cdccollins cdccollins mentioned this pull request Jan 2, 2024
Merged
@cdccollins cdccollins force-pushed the ownership-certificate branch 5 times, most recently from 11eb085 to a764906 Compare January 2, 2024 15:29
@cdccollins cdccollins force-pushed the ownership-certificate branch 3 times, most recently from 77b9e9d to 32dd4c6 Compare January 3, 2024 09:22
@cdccollins cdccollins marked this pull request as ready for review January 3, 2024 10:16
benjamineskola
benjamineskola approved these changes Jan 5, 2024
View reviewed changes
app/controllers/ownership_certificates_controller.rb
Comment on lines +12 to +16
def show
end

def edit
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to keep these around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those are views that are used!

@cdccollins cdccollins merged commit 259fc40 into main Jan 8, 2024
16 checks passed
@cdccollins cdccollins deleted the ownership-certificate branch January 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamineskola benjamineskola benjamineskola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdccollins @benjamineskola