Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not read from ENV directly post initialization #181

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Do not read from ENV directly post initialization #181

merged 3 commits into from
Nov 30, 2023

Conversation

benjamineskola
Copy link
Contributor

  • Don't use ENV.fetch with a default of nil
  • Do not read from ENV directly post initialization
  • Tidy up .rubocop.yml

@benjamineskola benjamineskola merged commit f527deb into main Nov 30, 2023
14 checks passed
@benjamineskola benjamineskola deleted the tidy-env-access branch November 30, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbaumann95 benbaumann95 benbaumann95 approved these changes

@EGiataganas EGiataganas EGiataganas approved these changes

@pixeltrix pixeltrix pixeltrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamineskola @pixeltrix @EGiataganas @benbaumann95