Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: double declare uui-h styles to bring back previous specificity #965

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

madsrasmussen
Copy link
Contributor

Description

After we allowed .uui-h* classes to be used outside a .uui-text container it got a lower specifity. I have fixed this so it is still possible to use the styles like previously.

How to test:

  • Make sure the .uui-h* styles work outside a .uui-text container.
  • Make sure you can override a h1, h2, h3 style inside a .uui-text container with a .uui-h* class.
  • Example <div class="uui-text"><h1 class="uui-h3">This should have h3 styling</h1></div>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

@iOvergaard iOvergaard added the bug Something isn't working label Nov 25, 2024
Copy link
Member

@leekelleher leekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out, the fix works. 🤠

@leekelleher leekelleher merged commit 012ffee into v1/contrib Nov 25, 2024
9 of 11 checks passed
@leekelleher leekelleher deleted the v1/bugfix/uui-h-class-specificity branch November 25, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants