Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ability to prevent modal close #953

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 12, 2024

I was moving fast and accidentally build on top of this one, so please merge this first:
#950

Correcting the ability to prevent a modal from closing
Added tests a updated docs.

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-953.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-953.westeurope.azurestaticapps.net

@madsrasmussen madsrasmussen merged commit ed30b6d into v1/contrib Nov 18, 2024
8 checks passed
@madsrasmussen madsrasmussen deleted the v1/feature/uui-modal-prevent-close branch November 18, 2024 11:26
nielslyngsoe added a commit that referenced this pull request Nov 20, 2024
* set to flex grow

* ability to prevent close + docs + tests

* rename to forceClose

* correct comment

---------

Co-authored-by: Mads Rasmussen <[email protected]>
@nielslyngsoe nielslyngsoe added bug Something isn't working feature Something we are looking to build and removed bug Something isn't working labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we are looking to build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants