Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of menu-item parts #935

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

skttl
Copy link
Contributor

@skttl skttl commented Oct 14, 2024

One of the things that really hurts my eyes when looking at the new backoffice, is that things feel off and misaligned. So I dug a bit in the menu item component and found some improvements.

Description

I moved the caret for displaying children further to the right, to make it visually connect with the menu item. Previously it looked closer to the browser edge (and also vertically unbalanced) than to the menu item itself.

I also added an aspect-ratio to the caret, to make the browser render a square box for it (instead of 12x17 pixels), which made it connect to the baseline of the label text.

I bumped the font-size of the icon to 15.66px, to make it render a 18x18 icon, instead of 18.39x.18.x39 which caused subpixel issues.

You can see a zoomed in before and after here: (after is the left one, note the improved symmetry in the icon rendering, and the flushing of baselines on the caret and label)

image

Motivation and context

It makes the menu item look less half baked.

How to test?

Screenshots (if appropriate)

Checklist

  • I have read the CONTRIBUTING document.

Copy link

Hi there @skttl, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link

@madsrasmussen madsrasmussen enabled auto-merge (squash) November 19, 2024 11:22
@madsrasmussen madsrasmussen merged commit c28c618 into umbraco:v1/contrib Nov 19, 2024
7 of 8 checks passed
@skttl
Copy link
Contributor Author

skttl commented Nov 19, 2024

Thanks @madsrasmussen :)

nielslyngsoe pushed a commit that referenced this pull request Nov 20, 2024
* Fix alignment of menu-item parts

* apply suggestion from Bjarne

---------

Co-authored-by: Mads Rasmussen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants