Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: UUIFormControlMixinClass: Dont call setAttribute in the constructor #931

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Bugfix: UUIFormControlMixinClass: Dont call setAttribute in the constructor #931

merged 1 commit into from
Oct 11, 2024

Conversation

JesmoDev
Copy link
Contributor

Having setAttribute in the constructor is no longer allowed and causes some components in New Backoffice to throw errors and not render.

This fixes it by setting the property instead.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-931.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Oct 11, 2024
@iOvergaard iOvergaard enabled auto-merge (squash) October 11, 2024 11:16
@iOvergaard iOvergaard disabled auto-merge October 11, 2024 11:17
@iOvergaard iOvergaard enabled auto-merge (squash) October 11, 2024 11:17
@iOvergaard iOvergaard merged commit a7ca074 into v1/contrib Oct 11, 2024
11 of 12 checks passed
@iOvergaard iOvergaard deleted the v1/bugfix/setAttribute-not-allowed-in-constructor branch October 11, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesmoDev @iOvergaard