Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Readonly state for uui-color-slider #917

Merged
merged 1 commit into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions packages/uui-color-slider/lib/uui-color-slider.element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,22 @@ export class UUIColorSliderElement extends LabelMixin('label', LitElement) {
@property() value = 0;

/**
* Disables the color slider.
* Sets the color slider to readonly mode.
* @type {boolean}
* @attr
* @default false
*/
@property({ type: Boolean, reflect: true })
readonly = false;

/**
* Sets the color slider to disabled.
* @type {boolean}
* @attr
* @default false
**/
@property({ type: Boolean, reflect: true }) disabled = false;
@property({ type: Boolean, reflect: true })
disabled = false;

private container!: HTMLElement;
private handle!: HTMLElement;
Expand All @@ -115,7 +125,8 @@ export class UUIColorSliderElement extends LabelMixin('label', LitElement) {
}

handleDrag(event: PointerEvent) {
if (this.disabled || !this.container || !this.handle) return;
if (this.disabled || this.readonly || !this.container || !this.handle)
return;

const { width, height } = this.container.getBoundingClientRect();

Expand All @@ -140,7 +151,7 @@ export class UUIColorSliderElement extends LabelMixin('label', LitElement) {
}

handleClick(event: MouseEvent) {
if (this.disabled) return;
if (this.disabled || this.readonly) return;

this.value = this.getValueFromMousePosition(event);
this.syncValues();
Expand Down Expand Up @@ -258,7 +269,8 @@ export class UUIColorSliderElement extends LabelMixin('label', LitElement) {
<span
id="color-slider__handle"
style="--current-value: ${this.cssPropCurrentValue}%;"
tabindex=${ifDefined(this.disabled ? undefined : '0')}></span>
tabindex=${ifDefined(this.disabled ? undefined : '0')}>
</span>
</div>
${Math.round(this.value)}`;
}
Expand Down Expand Up @@ -340,6 +352,14 @@ export class UUIColorSliderElement extends LabelMixin('label', LitElement) {
opacity: 0.55;
}

:host([readonly]) {
cursor: default;
}

:host([readonly]) #color-slider {
pointer-events: none;
}

#color-slider__handle {
position: absolute;
top: calc(50% - var(--uui-slider-handle-size) / 2);
Expand Down
16 changes: 15 additions & 1 deletion packages/uui-color-slider/lib/uui-color-slider.story.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,21 @@ export const Disabled: Story = {
parameters: {
docs: {
source: {
code: `<uui-color-slider label="Slider label" disabled="true"></uui-color-slider>`,
code: `<uui-color-slider label="Slider label" disabled></uui-color-slider>`,
},
},
},
};

export const Readonly: Story = {
args: {
readonly: true,
value: 50,
},
parameters: {
docs: {
source: {
code: `<uui-color-slider label="Slider label" readonly></uui-color-slider>`,
},
},
},
Expand Down
Loading