Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prioritize component validation over native validation #885

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Fix: Prioritize component validation over native validation #885

merged 11 commits into from
Aug 28, 2024

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Aug 8, 2024 •
edited
Loading

Makes FormControlMixin only gives one message at a time. (To align with Backoffice)

Please merge this PR first:
#881

Only breaking in the way that the experience will change slightly, only showing one message at a time.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe changed the title V1/bugfix/input stop binding native input validation Fix: Prioritize component validation over native validation Aug 20, 2024
@nielslyngsoe nielslyngsoe requested a review from JesmoDev August 20, 2024 09:09
@nielslyngsoe nielslyngsoe enabled auto-merge (squash) August 20, 2024 09:09
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Aug 28, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-885.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe merged commit ae42d1f into v1/contrib Aug 28, 2024
8 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/input-stop-binding-native-input-validation branch August 28, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

@JesmoDev JesmoDev Awaiting requested review from JesmoDev

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard