Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: menu items hide actions #796

Merged
merged 2 commits into from
May 23, 2024

Conversation

JesmoDev
Copy link
Contributor

Sets the width of the uui-menu-item action slot to 0 when not hovered or focused (previously just opacity)
This gives the text in the menu item more space, which is useful in narrow layouts.

Example of problem: There's a lot of wasted space on the right side of the menu-item
image

Example form Storybook
Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@iOvergaard iOvergaard added the feature Something we are looking to build label May 23, 2024
@iOvergaard iOvergaard merged commit 9f07ae6 into v1/contrib May 23, 2024
9 of 11 checks passed
@iOvergaard iOvergaard deleted the v1/feature/menu-items-hide-actions branch May 23, 2024 13:08
@iOvergaard iOvergaard changed the title V1/feature/menu items hide actions feat: menu items hide actions May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something we are looking to build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants