Umbraco.CMS.Backoffice/issues/1668 - adds aria-label to expand symbol

[liamlaverty]

Currently the expand/carat symbol has no aria-label. This PR adds a non-localized label to that element to distinguish it from the main menu item's label.

I'm not clear on how to localize this content in the Umbraco.UI app. Ideally, the "show child items" would be translated. If there are any examples of localization in the library I could take a look at implementing that.

umbraco/Umbraco-CMS#16690

Description

Adds aria-label="show child items" to the caret-button on https://uui.umbraco.com/?path=/docs/uui-menu-item--docs

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ✅ ] New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

When using a screen reader, carats currently don't describe their role. This fails WCAG 2.0 & 2.1 rule 4.1.2 (provide a name/role/value).

How to test?

• Run the app
• Find a content item with a child item
• View in the console app to see "show child items"

Screenshots (if appropriate)

Checklist

• If my change requires a change to the documentation, I have updated the documentation in this pull request.
• [✅ ] I have read the CONTRIBUTING document.
• [ ❌ ] I have added tests to cover my changes.

[github-actions]

Hi there @liamlaverty, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[iOvergaard]

Hello, @liamlaverty

Thanks for this and sorry for the delay in testing it. There is no localization in the library, only in the surrounding apps such as the Backoffice, so any labels like this should ideally be set through a property with a fallback to English. If you would add that, then it would be perfect.